Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip "pull" command if using Kubernetes 1.10, which does not support it. #3832

Merged
merged 4 commits into from
Mar 20, 2019
Merged

Skip "pull" command if using Kubernetes 1.10, which does not support it. #3832

merged 4 commits into from
Mar 20, 2019

Conversation

tstromberg
Copy link
Contributor

@tstromberg tstromberg commented Mar 8, 2019 •
edited
Loading

kubeadm v1.10.x doesn't support it. Here's how it gets displayed with this PR:

✨  Preparing Kubernetes environment ...
🚜  Pulling images required by Kubernetes v1.10.0 ...
❌  Unable to pull images, which may be OK: pull command is not supported by kubeadm v1.10.0
🔄  Relaunching Kubernetes v1.10.0 using kubeadm ...

Closes #3824

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 8, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tstromberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2019
@tstromberg tstromberg added this to the v1.0.0 milestone Mar 11, 2019
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 20, 2019
@tstromberg tstromberg mentioned this pull request Mar 20, 2019
Closed
@tstromberg tstromberg changed the title Don't try to run the images pull command on old versions of kubeadm Fix "kubeadm pull" on v1.10 by using --kubeconfig instead of --config Mar 20, 2019
@tstromberg tstromberg changed the title Fix "kubeadm pull" on v1.10 by using --kubeconfig instead of --config Use --kubeconfig instead of --config on Kubernetes v1.10.x Mar 20, 2019
@tstromberg tstromberg changed the title Use --kubeconfig instead of --config on Kubernetes v1.10.x pull: Use --kubeconfig instead of --config on kubeadm v1.10 Mar 20, 2019
@tstromberg tstromberg changed the title pull: Use --kubeconfig instead of --config on kubeadm v1.10 Skip "pull" command if using Kubernetes 1.10, which does not support it. Mar 20, 2019
@tstromberg
Copy link
Contributor Author

FYI, this is the upstream PR where the pull command was finally implemented:
kubernetes/kubernetes#63833

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 20, 2019
@tstromberg tstromberg merged commit c1a0264 into kubernetes:master Mar 20, 2019
@tstromberg tstromberg deleted the k8s-v1.10.0 branch March 20, 2019 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc Awaiting requested review from dlorenc

@priyawadhwa priyawadhwa Awaiting requested review from priyawadhwa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tstromberg @k8s-ci-robot